Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use create_function() anywhere #16181

Merged
merged 1 commit into from Jul 6, 2020
Merged

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented Jul 6, 2020

create_function() is deprecated since PHP 7.2, not needed anymore since 5.2 and removed in PHP 8. So there should be no reason to use it in Matomo
https://www.php.net/manual/en/function.create-function.php

I did not test the functions in Date.php as honestly I don't understand what is going on there.

@Findus23 Findus23 added the Needs Review PRs that need a code review label Jul 6, 2020
@Findus23 Findus23 mentioned this pull request Jul 6, 2020
6 tasks
@diosmosis diosmosis merged commit e41fdc9 into 4.x-dev Jul 6, 2020
@diosmosis diosmosis deleted the dont-use-create_function branch July 6, 2020 18:41
@mattab mattab added this to the 4.0.0 milestone Jul 20, 2020
@MatomoForumNotifications

This pull request has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/fehlermeldung-create-function-bei-systemcheck/44795/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants