Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify developer changelog as it's not clear that we would keep BC for these #16170

Merged
merged 2 commits into from Jul 2, 2020

Conversation

mattab
Copy link
Member

@mattab mattab commented Jul 2, 2020

No description provided.

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jul 2, 2020
@mattab mattab added this to the 4.0.0 milestone Jul 2, 2020
CHANGELOG.md Outdated
@@ -24,7 +24,7 @@ The Product Changelog at **[matomo.org/changelog](https://matomo.org/changelog)*

#### Recommendations for Matomo JS tracker

The following changes are recommendations and don't have to be done as we will still support them for many years. However, it could change in the future.
These are only recommendations (because we will keep backward compatibility forever), but we recommend you update your code for consistency with the Matomo documentations:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattab that's because we might break BC in 5 years or so see #16085

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that there would be any reason to remove BC in the future, as they are just aliases and wouldn't conflicnt with other products/class names etc. that's why i thought better we don't plan to deprecate them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about These are only recommendations (because we will keep backward compatibility for many more years), but we do recommend you update your code for consistency and for future proofing your tracking:

@tsteur tsteur merged commit 54fc201 into 4.x-dev Jul 2, 2020
@tsteur tsteur deleted the dev_changelog_clarify branch July 2, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants