New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When a custom dimension is deleted, disable cron archiving for all segments that use this custom dimension #16152
Comments
FYI: Custom reports stores its segment definition in a custom reports table. So ideally this solution would trigger an event that lets other plugins know to modify all segments (this would be needed in custom dimensions, but maybe we can use some generic event so it also works in the future for other things maybe, not needed though), and offer a simple method to manipulate a segment (this would be needed in core), eg |
BTW the segment archiving problem is more a general core problem and does not only apply to custom dimensions. Same problem exists when deactivating a plugin that provides segments etc. Maybe the segment filter in core should simply ignore such failures and leave a segment filter out when it is not available? Whether the segment is valid would then be only checked when editing or adding a segment etc. |
👍 so to summarise the solution could be to do 2 separate changes:
|
we got this issue a few times over the last weeks, the last occurrence:
Full error message below (reproduced on several instances):
|
Context
When a custom dimension is delete, and possibly when it's deactivated (to be tested), then any segment that still use this custom dimension, will fail to process.
ERROR [2018-03-12 00:12:06] Got invalid response from API request: ?module=API&method=API.get&idSite=2&period=day&date=last52&format=php&trigger=archivephp. Response was 'a:2:{s:6:"result";s:5:"error";s:7:"message";s:81:"Segment 'dimension7' is not a supported segment. - caused by plugin CustomReports";}'
Segment 'dimension7' is not a supported segment. - caused by plugin CustomReports
Solution
The goal of this issue is to address the problem of the Cron archive only. Proposed solution:
segment
tableAs a result, the cron processing will not fail anymore, and all reports will be available, as expected.
The text was updated successfully, but these errors were encountered: