Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing test for mysqli #16108

Merged
merged 1 commit into from Jun 24, 2020
Merged

Fix failing test for mysqli #16108

merged 1 commit into from Jun 24, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 24, 2020

For some reason it seems on MySQLi the mysql error code is not included in the message and mysql also returns 0 as error code. But actually the exception has the correct error code 馃し

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 24, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Jun 24, 2020
@sgiehl sgiehl requested a review from tsteur June 24, 2020 11:22
@sgiehl sgiehl mentioned this pull request Jun 24, 2020
Merged
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jun 24, 2020
@tsteur tsteur merged commit b3bb82e into 4.x-dev Jun 24, 2020
@tsteur tsteur deleted the fixtest branch June 24, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur Awaiting requested review from tsteur

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur