Readds Custom Variables as submodule #16104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
This reverts commit 30b56dc.
|
Is there a reason to even keep it as a submodule for 4.0? |
|
Yes we're still supporting it for a while |
diosmosis
approved these changes
Jun 27, 2020
sgiehl
added a commit
that referenced
this pull request
Jul 1, 2020
* Removes CustomVariables plugin * removes CustomVariables plugin from core list * Move methods to get custom variables from request to the plugin * define visit fields to persist in plugin * do not use custom variables plugin if not available * adjust test requirements for CustomVariables plugin * Only execute update if plugin is installed * do not consider custom variables widget as api in tests * move autosuggest tests for custom variables to plugin * do not use custom variable segments in core tests * move multi column segment test to custom variables plugin * do not use custom variable segment in archive cron test * update access log to use new product view parameters instead of custom variables * move some custom variables based tests to plugin * Use Contents API instead of CustomVariables for CSV export tests * skip some tests if CustomVariables plugin is not available * Adjust tracker code generator tests to work without custom variables plugin * [TEMP] remove custom variables from system test output * adjust some tests to run without custom variables plugin * apply some review feedback * Readds Custom Variables as submodule (#16104) * Adds CustomVariables as submodule * Revert "[TEMP] remove custom variables from system test output" This reverts commit 30b56dc. * use submodule branch * test changes due to loading CustomVariables as submodule (plugin order) * updates some expected screenshots * improve test fixture * submodule update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #16090 and should be merged into it before merging it.
Reason for having two PRs is to check that Matomo (the tests) are running without the plugin (see build results from #16090). That's important to prove Matomo 4 will also run without the plugin being installed at all. This PR readds the plugin as a submodule and updates the expected test files again...
Note: Some submodule plugin tests are still failing and should be updated when merging...