also support python 3.8 #16100
Merged
also support python 3.8 #16100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Findus23
added
the
not-in-changelog
tsteur
reviewed
Jun 22, 2020
| @@ -126,7 +126,7 @@ The following changes are recommendations and don't have to be done as we will s | |||
|
|
|||
| ### Other Breaking changes | |||
|
|
|||
| * The log importer in `misc/log-analytics` now supports Python 3 (3.5, 3.6 or 3.7), it will no longer run with Python 2. If you have any automated scripts that run the importer, you will have to change them to use the Python 3 executable instead. | |||
| * The log importer in `misc/log-analytics` now supports Python 3 (3.5, 3.6, 3.7 or 3.8), it will no longer run with Python 2. If you have any automated scripts that run the importer, you will have to change them to use the Python 3 executable instead. | |||
There was a problem hiding this comment.
fyi added a note to https://github.com/matomo-org/matomo/wiki/Matomo-4.0.0-release-notes
Can people maybe still checkout an earlier version from the log importer repository supporting Python 2? Could mention it maybe but should be enough to have this mentioned in the announcement as it's not really developer related.
There was a problem hiding this comment.
It should definitely be mentioned in the release notes with maybe a link to an FAQ explaining how to switch over.
I don't know of any breaking change that would cause the old script to not work with Matomo 4
diosmosis
pushed a commit
that referenced
this pull request
Jun 25, 2020
* also support python 3.8 * add or
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #16095
There should be no reason that log analytics doesn't work in 3.8 and the travis test runs for it:
https://github.com/matomo-org/matomo-log-analytics/blob/4.x-dev/.travis.yml#L7