Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluded Tracking IPs should also match anonymised IP #16094

Open
tsteur opened this issue Jun 20, 2020 · 1 comment
Open

Excluded Tracking IPs should also match anonymised IP #16094

tsteur opened this issue Jun 20, 2020 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Data Integrity & Accuracy c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Milestone
Priority Backlog ...

Comments

@tsteur
Copy link
Member

tsteur commented Jun 20, 2020

eg you have configured the IP to be anyonmised like 10.10.10.10 becomes 10.10.0.0.

All a user will see in the UI is 10.10.0.0. However, when trying to exclude that IP by entering 10.10.0.0, it won't exclude this IP because it's not matching the original 10.10.10.10 IP.

Most transparent for the user and intuitive be to also try and match the excluded IP against the anonymised IP. This way it works nicely for IPv4 and IPv6, is super easy to implement and transparent to the user.

We likely wouldn't want to convert an entered IP 10.10.0.0 to 10.10.*.* as it wouldn't be obvious why this is happening etc.
@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 20, 2020
@tsteur tsteur added this to the Priority Backlog (Help wanted) milestone Jun 20, 2020
@tsteur
Copy link
Member Author

tsteur commented Jun 22, 2020 •
edited by mattab

See https://wordpress.org/support/topic/getting-ip-based-exclusions-to-work/#post-13017864 we might also want to adjust the inline help depending on configured IP anonymisation maybe. For example:

Note: Your IP anonymization settings mask the final two bytes of IP addresses. Use 1.2.*.* to capture IP ranges you want to exclude

@mattab mattab added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. c: Data Integrity & Accuracy labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Data Integrity & Accuracy c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Milestone
Priority Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@tsteur @mattab