Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete segments when a site is deleted #16091

Merged
merged 2 commits into from Jun 21, 2020
Merged

Delete segments when a site is deleted #16091

merged 2 commits into from Jun 21, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 19, 2020

Was needed on Cloud. Can add a test if really needed.

@tsteur tsteur added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Jun 19, 2020
@tsteur tsteur added this to the 4.0.0 RC milestone Jun 19, 2020
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jun 19, 2020
@diosmosis diosmosis merged commit d14524a into 4.x-dev Jun 21, 2020
@diosmosis diosmosis deleted the deletesitesegment branch June 21, 2020 12:43
diosmosis pushed a commit that referenced this pull request Jun 25, 2020
* Delete segments when a site is deleted

* fix delete
@mattab mattab modified the milestones: 4.0.0-RC, 4.0.0 Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants