@sgiehl opened this Pull Request on June 18th 2020 Member

... and activate it automatically on update

refs #11524

Note: After merging this, we should remove the 4.x-dev branch of CustomDimensions plugin and migrate all issues.

@tsteur commented on June 23rd 2020 Member

LGTM and could point re migrating the issues. Guess we'll then also need to disable the issues in that repo plus mention maybe in 3.X readme which appears on the marketplace that the plugin is included in core directly from Matomo 4.

@sgiehl commented on June 29th 2020 Member

@tsteur I've updated the PR so it contains the latest changes that were done on the plugin repo. Could you maybe merge the PR, migrate the issues and remove the 4.x-dev branch on the plugin repo maybe?
I've checked that there are no more open PRs or branches that may contain any changes that would need to be migrated...

@tsteur commented on June 29th 2020 Member

Merged and migrated the issues. Made the 3.x-dev the default branch and kept 4.x-dev branch for now but could also delete it.

This Pull Request was closed on June 29th 2020
Powered by GitHub Issue Mirror