Include CustomDimensions plugin in core #16086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
approved these changes
Jun 23, 2020
|
LGTM and could point re migrating the issues. Guess we'll then also need to disable the issues in that repo plus mention maybe in 3.X readme which appears on the marketplace that the plugin is included in core directly from Matomo 4. |
… plugin description to translations
…ivate it on update
|
@tsteur I've updated the PR so it contains the latest changes that were done on the plugin repo. Could you maybe merge the PR, migrate the issues and remove the 4.x-dev branch on the plugin repo maybe? |
|
Merged and migrated the issues. Made the 3.x-dev the default branch and kept 4.x-dev branch for now but could also delete it. |
mattab
added a commit
to innocraft/matomo-enterprise
that referenced
this pull request
Nov 29, 2020
mattab
added a commit
to innocraft/matomo-enterprise
that referenced
this pull request
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and activate it automatically on update
refs #11524
Note: After merging this, we should remove the
4.x-devbranch of CustomDimensions plugin and migrate all issues.