Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document StaticContainer considered no longer API #16084

Merged
merged 1 commit into from Jun 18, 2020
Merged

Document StaticContainer considered no longer API #16084

merged 1 commit into from Jun 18, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 18, 2020

Forgot to document this one earlier. If somewhere constructor injection doesn't work, we'll need to either try to make it work there or tell them to still use staticcontainer for now. But it might just work for most plugins.

FYI will merge right away. Feel free to comment if I should change anything.

@tsteur
Document StaticContainer considered no longer API
4bc1538 
Forgot to document this one earlier. If somewhere constructor injection doesn't work, we'll need to either try to make it work there or tell them to still use staticcontainer for now. But it might just work for most plugins.
@tsteur tsteur added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 18, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jun 18, 2020
@tsteur tsteur merged commit b4cf458 into 4.x-dev Jun 18, 2020
@tsteur tsteur deleted the staticcontainerapidoc branch June 18, 2020 02:30
diosmosis pushed a commit that referenced this pull request Jun 25, 2020
@tsteur @diosmosis
Document StaticContainer considered no longer API (#16084)
f41e5c1 
Forgot to document this one earlier. If somewhere constructor injection doesn't work, we'll need to either try to make it work there or tell them to still use staticcontainer for now. But it might just work for most plugins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tsteur