Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix materializecss modal options #16080

Merged
merged 1 commit into from Jun 17, 2020
Merged

Fix materializecss modal options #16080

merged 1 commit into from Jun 17, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 17, 2020

The options for materializecss modals have changed, but weren't updated with #14082
See https://materializecss.com/modals.html#options and http://archives.materializecss.com/0.100.2/modals.html#options

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 17, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Jun 17, 2020
@sgiehl sgiehl mentioned this pull request Jun 17, 2020
Merged
@tsteur tsteur merged commit 88a02b9 into 4.x-dev Jun 17, 2020
@tsteur tsteur deleted the modaloptions branch June 17, 2020 21:16
diosmosis pushed a commit that referenced this pull request Jun 25, 2020
@sgiehl @diosmosis
Fix materializecss modal options (#16080)
2e93467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur