New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run npm update and include node_modules #16079
Conversation
package.json
Outdated
@@ -31,19 +31,19 @@ | |||
"angular-cookies": "^1.8.0", | |||
"angular-mocks": "^1.8.0", | |||
"angular-sanitize": "^1.8.0", | |||
"chroma-js": "^0.6.3", | |||
"chroma-js": "^2.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually not sure re this update. doesn't have any benefits, but increased in size a lot. See #16034 (comment)
@diosmosis guess if we include the node_modules in core, we might need to remove the automatic |
Yes that be good 👍 |
1e24964
to
3656ab9
Compare
👍 looks all good from my perspective... be good if @sgiehl confirms too |
Looks good to me too. Guess we need to merge the change to travis-scripts to master and update the submodule here before merging... |
Fixes #16030
Also includes the node_modules folder as discussed on slack to keep matomo working for users who do not have servers with node and deploy from git.