@diosmosis opened this Pull Request on June 17th 2020 Member

Fixes #16030

Also includes the node_modules folder as discussed on slack to keep matomo working for users who do not have servers with node and deploy from git.

@sgiehl commented on June 24th 2020 Member

@diosmosis guess if we include the node_modules in core, we might need to remove the automatic npm update in travis builds again? so we can be sure all files that are needed are actually commited

@tsteur commented on June 24th 2020 Member

Yes that be good 👍

@diosmosis commented on June 25th 2020 Member

@sgiehl / @tsteur changes should be made.

@tsteur commented on June 25th 2020 Member

👍 looks all good from my perspective... be good if @sgiehl confirms too

@sgiehl commented on June 26th 2020 Member

Looks good to me too. Guess we need to merge the change to travis-scripts to master and update the submodule here before merging...

This Pull Request was closed on June 26th 2020
Powered by GitHub Issue Mirror