Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run npm update and include node_modules #16079

Merged
merged 12 commits into from Jun 26, 2020
Merged

Conversation

diosmosis
Copy link
Member

Fixes #16030

Also includes the node_modules folder as discussed on slack to keep matomo working for users who do not have servers with node and deploy from git.

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jun 17, 2020
@diosmosis diosmosis added this to the 4.0.0 milestone Jun 17, 2020
package.json Outdated
@@ -31,19 +31,19 @@
"angular-cookies": "^1.8.0",
"angular-mocks": "^1.8.0",
"angular-sanitize": "^1.8.0",
"chroma-js": "^0.6.3",
"chroma-js": "^2.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually not sure re this update. doesn't have any benefits, but increased in size a lot. See #16034 (comment)

@sgiehl
Copy link
Member

sgiehl commented Jun 24, 2020

@diosmosis guess if we include the node_modules in core, we might need to remove the automatic npm update in travis builds again? so we can be sure all files that are needed are actually commited

@tsteur
Copy link
Member

tsteur commented Jun 24, 2020

Yes that be good 👍

@diosmosis
Copy link
Member Author

@sgiehl / @tsteur changes should be made.

@tsteur
Copy link
Member

tsteur commented Jun 25, 2020

👍 looks all good from my perspective... be good if @sgiehl confirms too

@sgiehl
Copy link
Member

sgiehl commented Jun 26, 2020

Looks good to me too. Guess we need to merge the change to travis-scripts to master and update the submodule here before merging...

@diosmosis diosmosis merged commit b129469 into 4.x-dev Jun 26, 2020
@diosmosis diosmosis deleted the 12961-another-update branch June 26, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update individual libraries through npm
3 participants