Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legacy autoloader for 2.x-dev for smoother upgrades #16070

Merged
merged 5 commits into from Jun 16, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 15, 2020

refs #12420 see #16069 for explanation.

We need to create a new 2.X release for this.

@tsteur tsteur added the Needs Review PRs that need a code review label Jun 15, 2020
@tsteur tsteur added this to the 3.13.7 milestone Jun 15, 2020
@@ -207,7 +207,7 @@ private static function notifyIfEAcceleratorIsUsed()
*/
private static function getNextRequiredMinimumPHP()
{
return '5.5.9';
return '7.2.5';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benefit is that users will get a better warning

@tsteur tsteur requested a review from sgiehl June 15, 2020 22:24
if (strpos($className, 'Matomo\\') === 0) {
$newName = 'Piwik' . substr($className, 6);
if (class_exists($newName) && !class_exists($className, false)) {
@class_alias($newName, $className);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was added in 5.3.0 so that should be fine https://www.php.net/manual/en/function.class-alias.php

@tsteur tsteur merged commit ce90503 into 2.x-dev Jun 16, 2020
@tsteur tsteur deleted the legacyautoloader2x branch June 16, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants