Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention users should not share their token with anyone #16068

Merged
merged 3 commits into from Jun 17, 2020
Merged

Mention users should not share their token with anyone #16068

merged 3 commits into from Jun 17, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jun 15, 2020

while reviewing #16066 noticed we should mention this.

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Jun 15, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jun 15, 2020
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Jun 15, 2020
@sgiehl sgiehl merged commit 02f6eb5 into 4.x-dev Jun 17, 2020
@sgiehl sgiehl deleted the tokenauthshare branch June 17, 2020 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsteur @sgiehl