Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dashboard showing incorrect percentage on increases bigger than 1000% #16067

Closed
holtwick opened this issue Jun 15, 2020 · 3 comments · Fixed by #18099
Closed

Fix dashboard showing incorrect percentage on increases bigger than 1000% #16067

holtwick opened this issue Jun 15, 2020 · 3 comments · Fixed by #18099
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
4.6.0

Comments

@holtwick
Copy link

holtwick commented Jun 15, 2020 •
edited

My website increased traffic from about 100 visits to a few thousands. The percentage dropped down to a low number (3%) where instead it should show be above 1000%. Interestingly when sorting by evolution the order is correct, therefore I guess it is probably a display issue.

CleanShot 2020-06-15 at 10 53 10@2x

CleanShot 2020-06-15 at 10 58 50@2x
@sgiehl
Copy link
Member

sgiehl commented Jun 15, 2020

@holtwick Thanks for creating this issue. I've just tried to reproduce that locally by generating some local test data. Seems that happens as soon as the percentage exceeds 1000. We need to investigate that further.

@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label Jun 15, 2020
@tsteur tsteur added this to the Priority Backlog (Help wanted) milestone Jun 15, 2020
@sgiehl
Copy link
Member

sgiehl commented Jul 23, 2020

The problem seems to be, that numbers are all returned formatted and in JavaScript they are tried to parse to Integer, which has incorrect results for a string like 1,235.2%. The tooltip for the totals also show an incorrect percentage. In addition parsing numbers in languages that don't use a normal dash as indicator for negativ numbers might result in a complete fail...

@bx80
Copy link
Contributor

bx80 commented Nov 15, 2021

This issue has been fixed in #18099

@bx80 bx80 closed this as completed Nov 15, 2021
@justinvelluppillai justinvelluppillai modified the milestones: 4.7.0, 4.6.0 Nov 15, 2021
@justinvelluppillai justinvelluppillai linked a pull request Nov 15, 2021 that will close this issue
Proportional evolution comparison for incomplete periods #18099
Merged
11 tasks
@justinvelluppillai justinvelluppillai changed the title Dashboard percentage incorrect on massive increase Fix dashboard showing incorrect percentage on increases bigger than 1000% Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
4.6.0
Development

Successfully merging a pull request may close this issue.

Proportional evolution comparison for incomplete periods matomo-org/matomo
5 participants
@holtwick @tsteur @justinvelluppillai @sgiehl @bx80