Document which APIs break in particular for JSON response #16061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
not-in-changelog
sgiehl
reviewed
Jun 12, 2020
| * Goals.getGoal | ||
| * UsersManager.getUser | ||
| * UsersManager.getUserByEmail | ||
| * SitesManager.getSiteFromId |
There was a problem hiding this comment.
Wondering if it would make sense to add tests for those methods. Guess they are currently untested, as we didn't have any changes in expected results 🤔 Not needed for this PR though, but might be worth to create an issue maybe
There was a problem hiding this comment.
Was wondering this initially as well. Noticed we're using XML format in system tests and tests are actually covered by json renderer test itself. There shouldn't be a need to run each method with every format as be bit too much and making build slower etc. We even knew it was breaking API it was just not clear which ones are affected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #16009
These were the API's I could identify. Should there be more then we'll need to add them later too.