Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not load JS tracking code deferred #16055

Closed
tsteur opened this issue Jun 11, 2020 · 1 comment
Closed

Do not load JS tracking code deferred #16055

tsteur opened this issue Jun 11, 2020 · 1 comment
Assignees
@tsteur
Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
3.14.0

Comments

@tsteur
Copy link
Member

tsteur commented Jun 11, 2020

Currently we set async=true;defer=true;. However, most browsers support async so defer should be no longer set. This is recommended behavior and ensures a browser won't prefer defer over async (which be bad for performance).

Should be updated in generated tracking code and in docs. Only async=true should be set.
@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Performance For when we could improve the performance / speed of Matomo. labels Jun 11, 2020
@Findus23
Copy link
Member

Findus23 commented Jul 7, 2020

it seems like GA also only sets async, but not defer (#16189)

@tsteur tsteur mentioned this issue Jul 7, 2020
Merged
@tsteur tsteur self-assigned this Jul 7, 2020
This was referenced Jul 8, 2020
Closed
Merged
@tsteur tsteur added this to the 3.14.0 milestone Jul 8, 2020
@tsteur tsteur mentioned this issue Jul 8, 2020
Merged
@tsteur tsteur closed this as completed Jul 9, 2020
@tsteur tsteur mentioned this issue Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
c: Performance For when we could improve the performance / speed of Matomo. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
3.14.0
Development

No branches or pull requests
2 participants
@tsteur @Findus23