Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure to create security files for node_modules #16049

Merged
merged 1 commit into from Jun 10, 2020
Merged

Ensure to create security files for node_modules #16049

merged 1 commit into from Jun 10, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 10, 2020

fixes #16048

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 10, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Jun 10, 2020
@Findus23 Findus23 mentioned this pull request Jun 10, 2020
Closed
diosmosis
diosmosis reviewed Jun 10, 2020
View reviewed changes
core/Updates/4.0.0-b2.php
@@ -59,6 +60,8 @@ public function doUpdate(Updater $updater)
// switch to default provider if GeoIp Legacy was still in use
LocationProvider::setCurrentProvider(LocationProvider\DefaultProvider::ID);
}

ServerFilesGenerator::createFilesForSecurity();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to consider this out of scope, but would it make sense to do this on every update?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to create another issue @diosmosis 👍

diosmosis
diosmosis approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, left a comment otherwise can merge

@tsteur tsteur merged commit f87703a into 4.x-dev Jun 10, 2020
@tsteur tsteur deleted the filesecurity branch June 10, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

HtAccess and web config files not created for node_modules
3 participants
@sgiehl @diosmosis @tsteur