Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HtAccess and web config files not created for node_modules #16048

Closed
tsteur opened this issue Jun 10, 2020 · 2 comments · Fixed by #16049
Closed

HtAccess and web config files not created for node_modules #16048

tsteur opened this issue Jun 10, 2020 · 2 comments · Fixed by #16049
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.0.0

Comments

@tsteur
Copy link
Member

tsteur commented Jun 10, 2020

See eg https://github.com/matomo-org/matomo/blob/4.x-dev/plugins/Installation/ServerFilesGenerator.php#L65
but also for IIS we need to create htaccess file / web config file for the node_modules directory.

Might need to trigger the createFilesForSecurity() method in an update to ensure they exist (or maybe we do this on every update not sure)
@tsteur tsteur added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 10, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jun 10, 2020
@sgiehl sgiehl self-assigned this Jun 10, 2020
@sgiehl sgiehl mentioned this issue Jun 10, 2020
Merged
@Findus23
Copy link
Member

Also applied the change in matomo-org/matomo-nginx@565aeb5

The question is: Do we need people to access node_modules at all? If I understand #16049 correctly it still allows access to asset files there.

@tsteur
Copy link
Member Author

tsteur commented Jun 10, 2020

@Findus23 yes few files might be loaded individually depending on demand eg maybe iframeresizer etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Ensure to create security files for node_modules matomo-org/matomo
3 participants
@tsteur @sgiehl @Findus23