Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric format for page performance sparklines #16046

Merged
merged 1 commit into from Jun 9, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 9, 2020

In some languages (like German) the time format includes non breaking characters ( ). With the current way the metrics are formatted it results in   displayed in the UI.

image

Defining processed metrics seems to move the formatting to another place and fixes that issue.

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 9, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Jun 9, 2020
@tsteur tsteur merged commit 662cb67 into 4.x-dev Jun 9, 2020
@tsteur tsteur deleted the fixperformancemetrics branch June 9, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants