Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saving of personal settings #16045

Merged
merged 1 commit into from Jun 9, 2020
Merged

Fix saving of personal settings #16045

merged 1 commit into from Jun 9, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 9, 2020 •
edited

Saving the personal settings currently fails when the password isn't changed (and thus no modal is opened)

guess that's a regression from #14082

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 9, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Jun 9, 2020
@sgiehl sgiehl requested a review from diosmosis June 9, 2020 14:44
@sgiehl sgiehl changed the title Fix saving of general settings Fix saving of personal settings Jun 9, 2020
@diosmosis diosmosis merged commit fce95ca into 4.x-dev Jun 9, 2020
@diosmosis diosmosis deleted the fixsettings branch June 9, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis