Expose setVisitorId JS tracker method #16042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build js |
tsteur
commented
Jun 8, 2020
| @@ -3216,6 +3217,11 @@ function getVisitorIdFromCookie(tracker) { | |||
| var visitorId = tracker.getVisitorId(); | |||
| equal(visitorId, tracker.getVisitorId(), "Visitor ID is the same when called multiple times"); | |||
|
|
|||
| tracker.setVisitorId('invalid'); // invalid characters | |||
There was a problem hiding this comment.
setVisitorId is also tested in many other places in the tests
sgiehl
approved these changes
Jun 9, 2020
tsteur
added a commit
to matomo-org/developer-documentation
that referenced
this pull request
Jun 11, 2020
mattab
added
the
Enhancement
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed only in #15593 (comment) that it's actually not exposed. As we need this in one of our projects ourselves adding this to 3.x-dev. Will reference that PR where we use it as well. Had this already implemented in another repo not knowing it wasn't working.
we'll also need to document this afterwards on the JS tracker API.
fixes #12777