Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest version of iframeresizer #16038

Merged
merged 1 commit into from Jun 8, 2020
Merged

Use latest version of iframeresizer #16038

merged 1 commit into from Jun 8, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 8, 2020

There was an additional copy of the library in the CoreHome plugin.
Guess should be safe to use the npm version instead.

Note: IframeResizer v4 dropped support for IE < 11, but guess that should be fine, as we don't support older IEs with Matomo 4 as well.

and removes local copy
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Jun 8, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Jun 8, 2020
@diosmosis diosmosis merged commit 24b4096 into 4.x-dev Jun 8, 2020
@diosmosis diosmosis deleted the iframeresizer branch June 8, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants