Minor npm updates & ui test fixes #16034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Task
|
Updating chroma.js should also be possible as even though it is a major change it is only used for the color bars in maps. |
|
@Findus23 was wondering if that would have any benefit. The library seems to have a lot more features now, which increased the size quite a bit. See https://bundlephobia.com/result?p=chroma-js@0.6.3 |
|
also we are actually planning to replace the maps with something new, so guess that lib might get removed anyways... |
|
@sgiehl As the library is just a collection of equations it should be fine from a security point of view to stay with the old library. |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #16030