Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all our plugins and premium plugins to pass w/ updated frontend libs #16031

Closed
diosmosis opened this issue Jun 7, 2020 · 6 comments
Closed
Assignees
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@diosmosis
Copy link
Member

diosmosis commented Jun 7, 2020

Follow up for #14082

We probably want to start with our open source plugins where we basically want to ensure

  • all changes from 3.x are merged into 4.x
  • tests are running with the 4.x branch (not sure if that works already or whether it needs a beta?)
  • ideally we have a green build for the 4.x branch of each plugin
  • and maybe could also do some basic minimal functional test with each plugin with 4.x
  • we check the version constraints are good in plugin.json (version = 4.0.0 and we require Matomo 4)
  • once it’s all good we publish a new version for the plugin on the marketplace from the 4.x-dev branch by tagging it.
@diosmosis diosmosis added this to the 4.0.0 milestone Jun 7, 2020
@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label Jun 8, 2020
@sgiehl sgiehl modified the milestones: 4.0.0, 4.0.0 RC Jun 16, 2020
@tsteur tsteur changed the title Get premium plugins to pass w/ updated frontend libs Get all our plugins and premium plugins to pass w/ updated frontend libs Jul 7, 2020
@tsteur tsteur modified the milestones: 4.0.0 RC, 4.0.0 Jul 7, 2020
@diosmosis
Copy link
Member Author

Plugins known to be compatible:

  • plugins included with core
  • GoogleAnalyticsImporter
  • Funnels
  • Cohorts

@sgiehl
Copy link
Member

sgiehl commented Jul 22, 2020

@diosmosis
Copy link
Member Author

diosmosis commented Jul 28, 2020

Other plugins:

  • PaidAdvertisingPerformance (build passing)
  • SearchEngineKeywordsPerformance (build passing)
  • CustomReports
  • GoogleAnalyticsImporter
  • LoginSaml (pr created)
  • Funnels
  • Cohorts
  • InvalidateReports (build is passing)
  • HeatmapSessionRecording (pr created)
  • WhiteLabel (build is passing)
  • RollUpReporting (build is passing)
  • MediaAnalytics (pr created)
  • ProxySite (no travis build)
  • CustomTranslations (build is passing)
  • ActivityLog (build is passing)
  • UsersFlow (build passing)
  • AbTesting (build failing)
  • ServerFileSync (build failing)
  • FormAnalytics (build passing)
  • EnterpriseDemo (no build)
  • WooCommerceAnalytics (no build)
  • MultiChannelConversionAttribution (build passing)
  • JsTrackerCustom
  • Queued tracking
  • LoginLdap
  • VisitorGenerator
  • Security Info
  • Custom Alerts
  • Custom variables
  • Treemap visualisation
  • Login HTTP Auth (we no longer support this one)
  • Bandwidth
  • AnonymousPiwikUsageMeasurement
  • EnvironmentVariables
  • LogViewer
  • TasksTimetable
  • Migration
  • GoogleAnalyticsImporter
  • ClassicFontTheme
  • DeviceDetectorCache
  • Provider
  • MarketingCampaignsReporting
  • JsTrackerForceAsync
  • ForceSSL

@sgiehl feel free to edit this comment/check things off

@tsteur
Copy link
Member

tsteur commented Jul 28, 2020

@diosmosis @sgiehl added the Matomo plugins as well

@tsteur
Copy link
Member

tsteur commented Aug 26, 2020

fyi @sgiehl @diosmosis just went over all our plugins to make sure 3.X commits are merged into 4.X everywhere and it's all good now. Need to make sure from now on when merging a plugin PR to always merge 3.X and 4.X. It looks like we were already doing this anyway really well so just wanted to mention this is looking all good (as I recently had made few tweaks in some 3.X plugin versions)

@tsteur
Copy link
Member

tsteur commented Sep 3, 2020

closing this big issue for now 🚀 🥳

Cheers @diosmosis @sgiehl

We'll later again make sure all 4.x-dev branches are up to date and that all latest changes in 4.X have a release.

@tsteur tsteur closed this as completed Sep 3, 2020
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

5 participants