Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix details overlay for links in overlay mode #16016

Merged
merged 1 commit into from Jun 3, 2020
Merged

Fix details overlay for links in overlay mode #16016

merged 1 commit into from Jun 3, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 3, 2020

One overlay test (showing the link details) was failing for a while now. Just checked the reason and it turns out that was also caused by the switch to JSON2 as default, as the api result seems no longer wrapped in an array.

refs #16008, #16009, #8566

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Jun 3, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone Jun 3, 2020
@tsteur tsteur merged commit 2851045 into 4.x-dev Jun 3, 2020
@tsteur tsteur deleted the fixoverlaylinks branch June 3, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @tsteur