Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes some date comparison issues #16015

Merged
merged 1 commit into from Jun 3, 2020
Merged

Fixes some date comparison issues #16015

merged 1 commit into from Jun 3, 2020

Conversation

tassoman
Copy link
Contributor

@tassoman tassoman commented Jun 3, 2020 •
edited by mattab

  • ensure new date objects are returned
  • return chosen period when comparing with previous year

(Backporting to 3.x-dev)

#15583

@sgiehl @tassoman
Fixes some comparison issues (matomo-org#15583)
93ad3c7 
* ensure new date objects are returned

* return chosen period when comparing with previous year
@tassoman tassoman mentioned this pull request Jun 3, 2020
Closed
@sgiehl sgiehl added this to the 3.13.6 milestone Jun 3, 2020
@tsteur tsteur merged commit e0fb7b4 into matomo-org:3.x-dev Jun 3, 2020
@tassoman tassoman deleted the backport_15583 branch June 4, 2020 07:05
@mattab mattab changed the title Fixes some comparison issues (#15583) Fixes some date comparison issues Jun 4, 2020
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Jun 4, 2020
jonasgrilleres pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 22, 2020
@tassoman @sgiehl @jonasgrilleres
Fixes some comparison issues (matomo-org#15583) (matomo-org#16015)
a0e6f3e 
* ensure new date objects are returned

* return chosen period when comparing with previous year

Co-authored-by: Stefan Giehl <stefan@matomo.org>
jbuget pushed a commit to 1024pix/pix-analytics that referenced this pull request Sep 26, 2020
@tassoman @sgiehl @jbuget
Fixes some comparison issues (matomo-org#15583) (matomo-org#16015)
caf7814 
* ensure new date objects are returned

* return chosen period when comparing with previous year

Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Milestone
3.13.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tassoman @sgiehl @tsteur @mattab