@tassoman opened this Pull Request on June 1st 2020 Contributor

Composer was warning about old naming convention

@Findus23 commented on June 2nd 2020 Member

Doing this would be a breaking change as it would update the plugins to the ones where the classes are called Matomo (I think), so it can only be done in Matomo 4 (and has already been done there)

@tsteur commented on June 2nd 2020 Member

@Findus23 would this be also the case when the same versions are still in use? It's generally not needed to fix this though in 3.x-dev indeed since it's already fixed in 4.x-dev.

@sgiehl commented on June 3rd 2020 Member

It actually should work to merge this one. As we used the same repositories for both packages (before and after rename), all releases are actually available in both. That means older versions still have the older namespace...

@Findus23 commented on June 3rd 2020 Member

all releases are actually available in both

In that case it should work. I always assumed there would be no more piwik/ releases and only the newer versions in matomo/ releases.

@tassoman commented on June 3rd 2020 Contributor

I functionally tested my branch by browsing matomo locally after library update and didn't broke... Can't say if it's enough. Maybe I should do a test-run for a trustworthy check?

In my opinion, deprecation warnings in a production environment (3.x) it's a real warning.
I mean, if matomo/ is marked for development (4.x) shouldn't be flagged deprecating (piwik/)
So what shall we do? :thinking:

@tsteur commented on June 3rd 2020 Member

I'd be happy to merge with the updated component names. The problem is that there are several version updates in the composer lock which I'm not keen to merge right now as we have already released an RC.

We might be able to merge this after the next release as these library upgrades could break something. There are some tests failing also but not 100% sure this is related to it.

@tsteur commented on June 24th 2020 Member

Note: Was going to merge but seems some tests are failing. Most tests because of other reasons but need to check why some of the other ones fail before merging.

@tsteur commented on June 24th 2020 Member

Seems eg https://travis-ci.org/github/matomo-org/matomo/jobs/693471575#L898-L900 is failing
https://travis-ci.org/github/matomo-org/matomo/jobs/693471576#L987-L989 is failing as well.

Likely because the PDF lib was updated. Will probably need to fix these tests after merging.

Not sure if https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/40735/Dashboard_widget_move.png is caused by this PR or if it's random test failure.

@sgiehl commented on June 24th 2020 Member

Not sure if https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/40735/Dashboard_widget_move.png is caused by this PR or if it's random test failure.

That's a random failure I've seen before already. IIRC it is already fixed on 4.x-dev branch

@tassoman commented on July 13th 2020 Contributor

Thank you team :+1:

This Pull Request was closed on June 24th 2020
Powered by GitHub Issue Mirror