@tsteur opened this Pull Request on May 27th 2020 Member

As suggested in chat made this change to see if anything breaks.

There are some failing tests in CustomEvents and Content tracking but that's because of how the date was falsely used in the test fixture. Happy to update the tests and add a changelog entry if we are keen to merge this. Not sure what else it would maybe break that maybe isn't covered by tests.

@tsteur commented on May 27th 2020 Member

Any thoughts @sgiehl @diosmosis ?

@sgiehl commented on June 3rd 2020 Member

In general I would vote for fixing the tests and merging this change. That is actually the behavior I imho would have expected before 🙈

@tsteur commented on June 3rd 2020 Member

👍 fixed the tests @sgiehl

This Pull Request was closed on June 10th 2020
Powered by GitHub Issue Mirror