Tracker API speed: avoid DB query when recording historical data or other authenticated tracking requests #15986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was just looking into matomo-org/matomo-for-wordpress#288 and then noticed we always first issue a query against the user table before actually checking the cached data. Should a token be used with admin or write permission, then we actually save the user query. It shouldn't cause any security issue cause if the token is not a valid `admin` or `write` permission token, then below code would be still executed and eg the brute force check should be executed just like before.
tsteur
added
c: Performance
sgiehl
requested changes
May 26, 2020
tsteur
changed the title
|
Thanks @sgiehl the change fixed the tests |
mattab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was just looking into matomo-org/matomo-for-wordpress#288 and then noticed we always first issue a query against the user table before actually checking the cached data.
Should a token be used with admin or write permission, then we actually save the user query.
It shouldn't cause any security issue cause if the token is not a valid
adminorwritepermission token, then below code would be still executed and eg the brute force check should be executed just like before.