Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing Core/Access #15983

Merged
merged 5 commits into from May 26, 2020
Merged

Typing Core/Access #15983

merged 5 commits into from May 26, 2020

Conversation

tolbon
Copy link
Contributor

@tolbon tolbon commented May 25, 2020

Type Core/Access Folder
Add getHelpUrl URL for Write Role

@Findus23 Findus23 added the Needs Review PRs that need a code review label May 25, 2020
@tolbon
Copy link
Contributor Author

tolbon commented May 25, 2020

CI don't pass cause TagManagerPlugins I push a PR on this too

@tsteur
Copy link
Member

tsteur commented May 25, 2020

@tolbon I have merged the tag manager PR. Could you pull the changes from tag manager 4.x-dev branch and update the submodule for TagManager and push the change? Let me know if you need help with this.

@tolbon
Copy link
Contributor Author

tolbon commented May 25, 2020

Yeah Can you explain please I'm not easy with that !-_- sorry

@tsteur
Copy link
Member

tsteur commented May 25, 2020

Are you using the command line for working with git?
You would do something like this:

cd plugins/TagManager
git checkout 4.x-dev
git pull origin 4.x-dev
cd ../..
git add plugins/TagManager
git commit -m 'Update tag manager submodule'
git push origin typing_core_access

If you use some UI for this I can't really help you that much. Basically you'd just need to make sure your Git UI pulls the latest changes for the Tag Manager repository in the 4.x-dev standard branch and then you basically commit this update to your Matomo repository in this typing_core_access branch

@tolbon
Copy link
Contributor Author

tolbon commented May 26, 2020

Thank you so much. I am not easy with git (submodules etc...)

@tsteur
Copy link
Member

tsteur commented May 26, 2020

Thanks @tolbon updating the submodule worked 👍

@tsteur tsteur merged commit 588dd53 into matomo-org:4.x-dev May 26, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 4, 2020
@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants