Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS Tracker: require category and action in trackEvent #15980

Merged
merged 7 commits into from May 25, 2020
Merged

JS Tracker: require category and action in trackEvent #15980

merged 7 commits into from May 25, 2020

Conversation

Findus23
Copy link
Member

fixes #13165 with the suggesting from there

@Findus23 Findus23 added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Needs Review PRs that need a code review labels May 24, 2020
sgiehl
sgiehl reviewed May 24, 2020
View reviewed changes
js/piwik.js Outdated Show resolved Hide resolved
tsteur
tsteur reviewed May 24, 2020
View reviewed changes
js/piwik.js Outdated Show resolved Hide resolved
@Findus23
Copy link
Member Author

build js

@tsteur tsteur merged commit fae60db into 4.x-dev May 25, 2020
@tsteur tsteur deleted the require-category-and-action-in-logEvent branch May 25, 2020 21:14
@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
@mattab mattab changed the title require category and action in logEvent JS Tracker: require category and action in trackEvent Sep 28, 2020
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

@sgiehl sgiehl sgiehl left review comments

Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Issue in piwik.js function logEvent
4 participants
@Findus23 @tsteur @sgiehl @mattab