Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no cut-off icons in DataTables #15979

Merged
merged 3 commits into from Jun 29, 2020
Merged

no cut-off icons in DataTables #15979

merged 3 commits into from Jun 29, 2020

Conversation

Findus23
Copy link
Member

fixes #13256

Interestingly I can still reproduce the issue with Chromium 81 (noticable in the normal view and quite strongly when using a mobile view. (like in the screenshot of #13256)

Before:
grafik
After:
grafik

I'd wait with merging until #14082 is merged and all UI tests have been updated.

PS: Is it intentional that the vertical scroll bar is always shown?

@Findus23 Findus23 added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels May 24, 2020
@tsteur
Copy link
Member

tsteur commented Jun 24, 2020

@Findus23 that scroll bar shouldn't be always shown. I reckon we can merge this PR now though? Will trigger a new build so the screenshots can be updated.

@Findus23 Findus23 marked this pull request as ready for review June 24, 2020 10:19
@sgiehl sgiehl added this to the 4.0.0 milestone Jun 29, 2020
@sgiehl sgiehl merged commit 3ca33e2 into 4.x-dev Jun 29, 2020
@sgiehl sgiehl deleted the no-cut-off-icons branch June 29, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Icons not fully shown and shown not correctly
3 participants