Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Benchmark Unit Tests #15976

Merged
merged 1 commit into from May 24, 2020
Merged

remove Benchmark Unit Tests #15976

merged 1 commit into from May 24, 2020

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented May 23, 2020 •
edited

"fixes" #13398
could one day be replaced with #7889

if it was unmaintained in 2018 and it seems like all inherited methods don't exist anymore, I guess we can delete it now.

@Findus23 Findus23 added the Needs Review PRs that need a code review label May 23, 2020
@Findus23 Findus23 linked an issue May 23, 2020 that may be closed by this pull request
undefined method createTestConfig() in BenchmarkTestCase #13398
Closed
@tsteur tsteur merged commit 87a6c79 into 4.x-dev May 24, 2020
@tsteur tsteur deleted the remove-benchmark-unit-tests branch May 24, 2020 20:34
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 4, 2020
@mattab mattab added this to the 4.0.0 milestone Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

undefined method createTestConfig() in BenchmarkTestCase
3 participants
@Findus23 @tsteur @mattab