Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update php-di to latest version 6.x #15974

Closed
Findus23 opened this issue May 23, 2020 · 1 comment · Fixed by #16311
Closed

update php-di to latest version 6.x #15974

Findus23 opened this issue May 23, 2020 · 1 comment · Fixed by #16311
Assignees
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@Findus23
Copy link
Member

see #15961 (comment)

branch with simple test by @sgiehl:
https://github.com/matomo-org/matomo/compare/phpdi

This fixes the deprecation warning of a dependency:

Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.

Migration guide: https://github.com/PHP-DI/PHP-DI/blob/6.0.0/doc/migration/6.0.md
Changelogs: https://github.com/PHP-DI/PHP-DI/releases

@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label May 23, 2020
@tsteur tsteur added this to the 4.0.0 milestone Aug 13, 2020
@Findus23
Copy link
Member Author

This will also be needed to include the fix for PHP 8 compatibility: PHP-DI/PHP-DI#727

@Findus23 Findus23 mentioned this issue Aug 17, 2020
6 tasks
@sgiehl sgiehl self-assigned this Aug 25, 2020
@mattab mattab changed the title update php-di to latest version (5->6) update php-di to latest version 6.x Sep 28, 2020
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants