New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing link to consent help page #15973
Conversation
It seems like there are a lot more links missing (two in the first paragraph). Was this intentional? |
Probably when we added this these links maybe didn't exist yet? Not sure. Are you planning on adding more links @Findus23 ? |
@Findus23 can this one be merged? |
@tsteur It should be finished now (apart from the UI tests) |
👍 will you update them or should I? |
I don't have as much time at the moment and am not up to date with which PRs modified the UI tests, so it would be great if someone else could do it. |
@diosmosis do you maybe know why these tests for the PR would always fail: https://travis-ci.org/github/matomo-org/matomo/builds/702234148 Tried to restart the tests and commit them again but they always fail... even merged 4.x-dev into it but still ails... there is no file change though that would explain this.... could also just merge and see if it then still has a problem but not sure what's happening. Funnily the PUSH PR passes and it should be in the end the same as the PR build |
@tsteur I've seen it before but don't know why I happens. the build will continue to fail until a new commit is pushed. Probably some travis-ci bug. |
Pushed already 3 times or so... still happening... @diosmosis do you reckon it might be fine once merged? Guess could always revert the PR if it makes the 4.x-dev branch fail later |
@tsteur the push build is fine, so I say merge? If it's just the PR build, it won't have any effect on the 4.x-dev build. And of course for branches we don't need both. |
Worked... interestingly there was a screenshot failure now in 4.x-dev which passed in the PULL build which shouldn't have. Something went wrong there with Github :) Will fix that screenshot in a new PR |
This link from https://developer.matomo.org/guides/tracking-javascript-guide#asking-for-consent is missing in the Matomo page version.
Interestingly it didn't get lost in #15557 but was already missing before.