Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing link to consent help page #15973

Merged
merged 6 commits into from Jun 28, 2020
Merged

Conversation

Findus23
Copy link
Member

This link from https://developer.matomo.org/guides/tracking-javascript-guide#asking-for-consent is missing in the Matomo page version.

Interestingly it didn't get lost in #15557 but was already missing before.

@Findus23 Findus23 added Needs Review PRs that need a code review c: i18n For issues around internationalisation and localisation. labels May 23, 2020
@Findus23 Findus23 added this to the 4.0.0 milestone May 23, 2020
@Findus23
Copy link
Member Author

It seems like there are a lot more links missing (two in the first paragraph). Was this intentional?

@Findus23 Findus23 marked this pull request as draft May 23, 2020 15:58
@tsteur
Copy link
Member

tsteur commented May 26, 2020

Probably when we added this these links maybe didn't exist yet? Not sure. Are you planning on adding more links @Findus23 ?

@tsteur
Copy link
Member

tsteur commented Jun 24, 2020

@Findus23 can this one be merged?

@Findus23 Findus23 marked this pull request as ready for review June 24, 2020 10:39
@Findus23
Copy link
Member Author

@tsteur It should be finished now (apart from the UI tests)

@tsteur
Copy link
Member

tsteur commented Jun 24, 2020

👍 will you update them or should I?

@Findus23
Copy link
Member Author

I don't have as much time at the moment and am not up to date with which PRs modified the UI tests, so it would be great if someone else could do it.

@tsteur
Copy link
Member

tsteur commented Jun 26, 2020

@diosmosis do you maybe know why these tests for the PR would always fail: https://travis-ci.org/github/matomo-org/matomo/builds/702234148

Tried to restart the tests and commit them again but they always fail... even merged 4.x-dev into it but still ails... there is no file change though that would explain this.... could also just merge and see if it then still has a problem but not sure what's happening.

Funnily the PUSH PR passes and it should be in the end the same as the PR build

@diosmosis
Copy link
Member

diosmosis commented Jun 27, 2020

@tsteur I've seen it before but don't know why I happens. the build will continue to fail until a new commit is pushed. Probably some travis-ci bug.

@tsteur
Copy link
Member

tsteur commented Jun 27, 2020

Pushed already 3 times or so... still happening... @diosmosis do you reckon it might be fine once merged? Guess could always revert the PR if it makes the 4.x-dev branch fail later

@diosmosis
Copy link
Member

@tsteur the push build is fine, so I say merge? If it's just the PR build, it won't have any effect on the 4.x-dev build. And of course for branches we don't need both.

@tsteur tsteur merged commit 764068c into 4.x-dev Jun 28, 2020
@tsteur tsteur deleted the add-link-to-asking-consent branch June 28, 2020 07:16
@tsteur
Copy link
Member

tsteur commented Jun 28, 2020

Worked... interestingly there was a screenshot failure now in 4.x-dev which passed in the PULL build which shouldn't have. Something went wrong there with Github :) Will fix that screenshot in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants