Fix theme rewrite removes src attribute when custom plugin directory is used #15965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is used Noticed this in Matomo for WordPress which makes use of the ability to define custom plugin directories.
sgiehl
approved these changes
May 20, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
…is used (matomo-org#15965) Noticed this in Matomo for WordPress which makes use of the ability to define custom plugin directories.
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
…is used (matomo-org#15965) Noticed this in Matomo for WordPress which makes use of the ability to define custom plugin directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this in Matomo for WordPress which makes use of the ability to define custom plugin directories.
Matomo was supposed to rewrite this
img srcpathto this:
but I got this:
and as a result the images weren't shown
While debugging I noticed it was returning a path
../../plugins/...when it should have returnedsrc="../../plugins/.."see content of$sourceWith the patch things work. Not sure how this worked before and if it actually worked.