Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer dependency warnings when installing Matomo from git on a test server #15961

Closed
tassoman opened this issue May 18, 2020 · 9 comments · Fixed by #15962
Closed

Composer dependency warnings when installing Matomo from git on a test server #15961

tassoman opened this issue May 18, 2020 · 9 comments · Fixed by #15962
Assignees
@sgiehl
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
4.0.0

Comments

@tassoman
Copy link
Contributor

I've cloned this repository but I got two deprecation warnings:

Package guzzle/guzzle is abandoned, you should avoid using it. Use guzzlehttp/guzzle instead.
guzzle/guzzle suggests installing guzzlehttp/guzzle (Guzzle 5 has moved to a new package name. The package you have installed, Guzzle 3, is deprecated.)

Then I got another deprecation warning:

Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
@tassoman
Copy link
Contributor Author

tassoman commented May 18, 2020 •
edited

Ok. I sorted out this issue can be a duplicate of #11318 and #9531
I've digged in, also. Discovering a pretty fresh feedback from aws developers.
Maybe this problem with Guzzle promises can be solved somehow in Matomo project?

@sgiehl
Copy link
Member

sgiehl commented May 18, 2020

Did you install with development dependencies? the aws package is development only

@Findus23
Copy link
Member

@sgiehl Do you know what aws/aws-sdk-php is used for? I think only https://github.com/matomo-org/matomo/tree/4.x-dev/plugins/TestRunner/Aws uses it which I don't think anyone uses anymore.
So maybe we could remove it with Matomo 4 or at least update the package to the latest version.

@tassoman
Copy link
Contributor Author

@sgiehl I ran composer install then enabled php console development:enable

@sgiehl
Copy link
Member

sgiehl commented May 19, 2020

@tassoman guzzle has been removed with #15962
Removing/Updating container-interop won't be that easy as we need to update php-di for that, which needs some more changes...

@tassoman
Copy link
Contributor Author

Thank you, good shot!
Would you like I file another issue splitting the two dependencies or we just fade out this issue?

I've digged into the container-interop deprecation and I discovered is about merging into PSR-11.

@sgiehl
Copy link
Member

sgiehl commented May 19, 2020

already tried updating php-di on a new branch, but tests are failing and there are some issues with having references in functions defined in configuration like here

matomo/config/environment/test.php

Line 101 in 0187b71

array('AssetManager.getStylesheetFiles', function (&$stylesheets) {

Don't have time to dig deeper into that right now. Feel free to simply rename this issue or create a new one for updating php-di

@tsteur
Copy link
Member

tsteur commented May 19, 2020

Be indeed good to create a new issue for the other one and we close this one.

We'll see when we look into the other one as it might not have highest priority right now while working on Matomo 4.

Thanks for bringing this up @tassoman

@Findus23 Findus23 added the Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. label May 23, 2020
@Findus23 Findus23 linked a pull request May 23, 2020 that will close this issue
Removes AWS test runner #15962
Merged
@Findus23 Findus23 mentioned this issue May 23, 2020
Closed
@Findus23
Copy link
Member

Created #15974 for this.

@sgiehl sgiehl added this to the 4.0.0 milestone May 25, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 28, 2020
@mattab mattab changed the title Guzzle 3 is deprecated (composer dependency warnings) Composer dependency warnings when installing Matomo from git on a test server Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Removes AWS test runner matomo-org/matomo
5 participants
@tassoman @tsteur @mattab @sgiehl @Findus23