Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using matomo prefixed parameters for campaigns such as matomo_campaig/mtm_campaign #15957

Merged
merged 5 commits into from May 19, 2020
Merged

Allow using matomo prefixed parameters for campaigns such as matomo_campaig/mtm_campaign #15957

merged 5 commits into from May 19, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 15, 2020

Shall we maybe also add something like mtm_campaign?

refs #12420

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 15, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone May 15, 2020
@sgiehl sgiehl mentioned this pull request May 15, 2020
Merged
@diosmosis
Copy link
Member

Seems strange to not use allow mtm_ prefix as well.

@tsteur
Copy link
Member

tsteur commented May 17, 2020

btw mtm stands for matomo tag manager. Of course could also stand for matomo :) I have not really and preference but maybe wouldn't provide too many options. I can't really think of a reason why it would be an issue for people to still use pk_ but could also allow mtm additionally

@sgiehl
Copy link
Member Author

sgiehl commented May 18, 2020

also added the mtm_ prefixes. We maybe should update the documentation for Matomo 4 later so we suggest to use the new parameter names...

@diosmosis
Copy link
Member

Weird, the build didn't run for this PR?

@sgiehl
Copy link
Member Author

sgiehl commented May 19, 2020

build js

@sgiehl
Copy link
Member Author

sgiehl commented May 19, 2020

Weird, the build didn't run for this PR?

It actually did, but it's not linked here 🤷

@diosmosis diosmosis merged commit 1933b18 into 4.x-dev May 19, 2020
@diosmosis diosmosis deleted the campaignparams branch May 19, 2020 23:11
@mattab mattab mentioned this pull request Jun 5, 2020
Open
21 tasks
@mattab mattab changed the title Allow using matomo prefixed parameters for campaigns Allow using matomo prefixed parameters for campaigns such as matomo_campaig/mtm_campaign Sep 29, 2020
@mattab mattab added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgiehl @diosmosis @tsteur @mattab