Fix a plugin that enriches the tracker needed to mark plugin as tracker #15954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
Needs Review
tsteur
changed the title
sgiehl
approved these changes
May 15, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #11572 (comment)
This was actually a regression in a19d8cf#diff-bd3c3d13cfeffe365775c155d287ccdbL52-L70 as there shouldn't be a need to mark a plugin as a tracker just because it defines a
tracker.js. Defining it as a tracker is not needed unless it would actually do something during tracking server side. Some plugins that extend tracker might only track additional events or other things though so it's not needed to mark the plugin as a tracker to keep tracking fast and not load unneeded plugins.Documented the tracker.js itself in matomo-org/developer-documentation#345 (which needs a review)