Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page performance shows up first in custom alerts and reports #15952

Merged
merged 3 commits into from May 14, 2020
Merged

Fix page performance shows up first in custom alerts and reports #15952

merged 3 commits into from May 14, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 14, 2020 •
edited

fix #15950

Tests should pass. The custom dimension tests might be easier to fix once the PR is merged or about to be merged.

@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels May 14, 2020
@tsteur tsteur added this to the 4.0.0 milestone May 14, 2020
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels May 14, 2020
@sgiehl sgiehl merged commit fb1be4d into 4.x-dev May 14, 2020
@sgiehl sgiehl deleted the m15950 branch May 14, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Performance Overview needs to set an orderId
2 participants
@tsteur @sgiehl