Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: preview mode based on cookies #15941

Closed
Laul0 opened this issue May 12, 2020 · 1 comment
Closed

Feature: preview mode based on cookies #15941

Laul0 opened this issue May 12, 2020 · 1 comment
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.

Comments

@Laul0
Copy link

Laul0 commented May 12, 2020

Summary

An over approach to display the debug console in preview mode based on Google Tag Manager experience

Current behavior

After enable the preview mode, you have to go the the target site and add arguments to the URL:

  • either ?mtmPreviewMode=[Tag Manager container ID]
  • or &mtmPreviewMode=[Tag Manager container ID]

Expected behavior

Once preview mode enable, go the the target site with the same browser and the debug console appears alone.
To hide the console, disable the preview mode.

The preview mode manage a cookie into the browser to determine if the debug console have to be displayed or not in addition to the Matomo Tag Manager configuration.

Additional information

Pros

  • Not need to add argument to the URL
  • Don't lost the argument when click on link (page navigation)
  • Based on cookies for the same browser (security - avoid that someone who know how to enable debug mode try to enable it)

Cons

  • Can't share the preview mode with other people
  • Have to use the same browser to display the debug console

That's it 🙂

Don't hesitate if you need some additional information.
@Laul0 Laul0 mentioned this issue May 14, 2020
Closed
@tsteur
Copy link
Member

tsteur commented May 14, 2020

Cheers @Laul0 closing this as a duplicate of matomo-org/tag-manager#217 As mentioned there we are setting a cookie already, but this only works when both Matomo and the site itself runs on the same domain so far.

@tsteur tsteur closed this as completed May 14, 2020
@tsteur tsteur added the duplicate For issues that already existed in our issue tracker and were reported previously. label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate For issues that already existed in our issue tracker and were reported previously.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsteur @Laul0