remove support for old format of adding custom search engines #15938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
|
btw all Events are marked as API unless we specifically say to ignore it. That's why it appears here: https://developer.matomo.org/api-reference/events#referreraddsearchengineurls should still be fine to merge though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess that shouldn't be needed anymore. Before Piwik 2.15 we used to have another array format for defining search engines. So if anyone would still use this old format with the event
Referrer.addSearchEngineUrls, that might not work anymore. But as that event is not even marked as API, I guess that should be fine.refs #8567