Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search engines are displayed in the wrong channel type #15923

Closed
PeteTrombone opened this issue May 7, 2020 · 8 comments · Fixed by #15951
Closed

Search engines are displayed in the wrong channel type #15923

PeteTrombone opened this issue May 7, 2020 · 8 comments · Fixed by #15951
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@PeteTrombone
Copy link

Search engine websites are displayed under the channel type "Websites".

image

In addition, there are also entries of the search engines under the channel type "Search Engines". However, these are completely different values.

image

When I look at the tracking data of the last years in Matomo, it always looks the same as above.

@tsteur
Copy link
Member

tsteur commented May 7, 2020

Thanks for reporting this issue @PeteTrombone

I can't really reproduce this just yet unfortunately. Is there any chance you could create an account for us with view access in your Matomo (email hello at matomo.org) so we can maybe look a bit more into the data?

@PeteTrombone
Copy link
Author

@tsteur you have received a mail from me (Jörg Zipf).

@tsteur
Copy link
Member

tsteur commented May 10, 2020

Thanks @PeteTrombone I've had a look but couldn't quite understand just yet how this would possibly happen. I've tried to reproduce using the same referrer url but always works here.

Any chance there are third party plugins activated? You can find out by going to
"Admin => Plugins". There you can filter by "Third party":

image

I suppose you are using the JavaScript tracker to track visits?

@PeteTrombone
Copy link
Author

@tsteur yes, we using the JavaScript tracker with the standard tracking code.

We have no third party plugins installed.

image

Here is the list of inactive plugins. Is that ok?
image

@tsteur
Copy link
Member

tsteur commented May 11, 2020

Thanks @PeteTrombone that looks all good.

I've been trying to reproduce a bit more but cannot. Also not seeing this issue in any of our other installations. So far I would only be able to explain this if

  • the file $matomoDir/vendor/matomo/searchengine-and-social-list/SearchEngines.yml is missing or incomplete
  • Or if the search engine definitions in the database is incomplete /

In case you have access to the database: Can you check if you get a result when executing this SQL query:

select FROM_BASE64(option_value) from `matomo_option` where option_name = 'SearchEngineDefinitions'

The table name for matomo_option might also be eg piwik_option or something similar depending on the configured database table prefix. Could you maybe send us the content of that result by email? Then we could check if it looks all good.

You might also want to check if as a fallback the above mentioned file exists (but I don't think that's the issue here)

@tsteur
Copy link
Member

tsteur commented May 14, 2020

I can reproduce this with this patch https://gist.github.com/tsteur/e07343f251eb630cd87bec4bc80fbf54

@PeteTrombone it seems like the information in the option table is a bit outdated. Is it possible that the setting General['enable_internet_features'] in config.ini.php is disabled?

If the server has a connection to the internet, then it should be possible to update this list and fix this issue by executing this command within the Matomo directory on the server directly:

./console core:run-scheduled-tasks  --force "Piwik\Plugins\Referrers\Tasks.updateSearchEngines"

To fix the issue in general maybe when we update Matomo, we should generally execute Option::delete(SearchEngine::OPTION_STORAGE_NAME). This way we would make sure that if you suddenly disable internet settings, the latest version will be used. It won't fix it though when there isn't an update for a while so we could just ignore any value in the options table when internet is enabled.

@tsteur tsteur added the Bug For errors / faults / flaws / inconsistencies etc. label May 14, 2020
@tsteur tsteur self-assigned this May 14, 2020
@PeteTrombone
Copy link
Author

@tsteur yes, the settting is disabled for security reasons.
Is there a way to do this offline? Is it possible to download and exchange a file?

@tsteur
Copy link
Member

tsteur commented May 14, 2020

@PeteTrombone do fix the issue I recommend to delete the above mentioned option entry by executing this SQL query:

delete from `matomo_option` where option_name = 'SearchEngineDefinitions'

Alternatively, executing the command described in #15923 (comment) should fix it too. We've already worked on a patch to fix the issue in general in the future as part of Matomo 4.

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants