Bind param values manually since PDOStatement::execute() will assume … #15919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…params are all strings. This causes null values to not be bound correctly.
tsteur
reviewed
May 6, 2020
| return $this->_stmt->execute($params); | ||
| } else { | ||
| return $this->_stmt->execute(); | ||
| foreach (array_values($params) as $index => $paramValue) { |
There was a problem hiding this comment.
btw does it make sense to add one integration test for this with a null value?
There was a problem hiding this comment.
👍 was planning to but forgot
There was a problem hiding this comment.
👍 code looks good otherwise and tested it locally, worked. feel free to merge once you've added a test. Must have been a hard find this bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…params are all strings. This causes null values to not be bound correctly.
I checked and mysqli appears to be fine.