Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GeoIP2 autoupdate #15916

Merged
merged 1 commit into from May 7, 2020
Merged

Fix GeoIP2 autoupdate #15916

merged 1 commit into from May 7, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 6, 2020 •
edited

Autoupdating the GeoIP2 database failed for me locally on 4.x-dev with

WARNING [2020-05-06 13:03:00] 27405  /srv/matomo/plugins/GeoIp2/LocationProvider/GeoIp2.php(109): Warning - strpos() expects parameter 1 to be string, array given - Matomo 4.0.0-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)
WARNING [2020-05-06 13:03:00] 27405  /srv/matomo/plugins/GeoIp2/LocationProvider/GeoIp2.php(109): Warning - file_exists() expects parameter 1 to be a valid path, array given - Matomo 4.0.0-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)
WARNING [2020-05-06 13:03:00] 27405  /srv/matomo/plugins/GeoIp2/LocationProvider/GeoIp2.php(113): Notice - Array to string conversion - Matomo 4.0.0-b1 - Please report this message in the Matomo forums: https://forum.matomo.org (please do a search first as it might have been reported already)

Seems that was the reason...

Regression from #15521

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels May 6, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone May 6, 2020
@diosmosis diosmosis merged commit 1ac50c2 into 4.x-dev May 7, 2020
@diosmosis diosmosis deleted the geoip2regression branch May 7, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis