Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure row actions are only bound once #15914

Merged
merged 1 commit into from May 6, 2020
Merged

Ensure row actions are only bound once #15914

merged 1 commit into from May 6, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 5, 2020

initTr seems to be called when a subtable is loaded, causing row action events to be bound multiple times.

fixes #15875

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 5, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone May 6, 2020
@sgiehl sgiehl merged commit be92d82 into 4.x-dev May 6, 2020
@sgiehl sgiehl deleted the fixrowactiontrigger branch May 6, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Row Evolution PopUp opens after Visitors Log Popup Closed
2 participants
@sgiehl @tsteur