Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Tracking API region has outdated definition #15911

Closed
ursNiemi opened this issue May 5, 2020 · 1 comment · Fixed by matomo-org/developer-documentation#341
Closed
Assignees
Labels
c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.

Comments

@ursNiemi
Copy link

ursNiemi commented May 5, 2020

In the documentation Tracking HTTP API, it says:

region — An override value for the region. Should be set to the two letter region code as defined by MaxMind's GeoIP databases. See here for a list of them for every country (the region codes are located in the second column, to the left of the region name and to the right of the country code).

It seems that the regions Matomo currently uses are not from that outdated file by MaxMind, but instead they conform to ISO-3166-2 regional codes (e.g. 19 regions for Finland, not the 5 in the MaxMind list).

The Matomo map cannot handle this information (separate issue), but with the standard ISO codes, visitor Region is set correctly at least in Finland.

@sgiehl
Copy link
Member

sgiehl commented May 5, 2020

Hi @ursNiemi. Thanks for letting us know. Seems we forgot to update the documentation when we implemented GeoIP2. At that point we switched from using the old Maxmind FIPS codes to ISO codes.

@sgiehl sgiehl added the c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. label May 5, 2020
@sgiehl sgiehl self-assigned this May 5, 2020
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Documentation For issues related to in-app product help messages, or to the Matomo knowledge base. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants