Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing HTTP method and version gracefully (trac #4352). #159

Closed
wants to merge 1 commit into from
Closed

Conversation

orlitzky
Copy link

I've attempted to fix http://dev.piwik.org/trac/ticket/4352 myself by making the HTTP method and versions (the spaces surrounding them, really) optional. With this patch, I was able to import a few hundred of our sites.

Feel free to cherry pick any/all of it and adjust the style.

@mattab
Copy link
Member

mattab commented Dec 8, 2013

Thanks for PR. Can you rebase on the latest master, then we can see if the code works (if Travis is green then your PR should mostly work). Also will be nice if you can add a test case showing the wrong input data in eg. https://github.com/piwik/piwik/blob/master/tests/resources/access-logs/fake_logs.log (at the end)

@mattab
Copy link
Member

mattab commented Dec 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants