Send onboarding email during installation #15894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In theory it should never matter if you are using SMTP or PHP mail (and therefore But maybe we should make the fact that the from address can not be detected automatically and this FAQ more prominently. Maybe even add a system check that looks up if the from mail ends with |
sgiehl
requested changes
May 11, 2020
Co-authored-by: Stefan Giehl <stefan@matomo.org>
|
Made the changes @sgiehl |
|
@sgiehl I suppose it is good to merge now? |
|
I still think that the subject line looks like a random SPAM mail. |
|
@Findus23 changed it 👍 |
sgiehl
approved these changes
May 15, 2020
jonasgrilleres
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 22, 2020
jbuget
pushed a commit
to 1024pix/pix-analytics
that referenced
this pull request
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs MAR-777
In my case it went into spam since the sender was basically
foo@mbp.localdomain. Not sure how often sending the mail actually works when no proper SMTP is configured and how often it would go to spam? Any thoughts @mattab @Findus23I'm catching any error that happens so hopefully this doesn't influence