@tsteur opened this Pull Request on May 1st 2020 Member

Refs MAR-777


In my case it went into spam since the sender was basically foo<a class='mention' href='https://github.com/mbp'>@mbp</a>.localdomain. Not sure how often sending the mail actually works when no proper SMTP is configured and how often it would go to spam? Any thoughts @mattab @Findus23

I'm catching any error that happens so hopefully this doesn't influence

@Findus23 commented on May 2nd 2020 Member

In theory it should never matter if you are using SMTP or PHP mail (and therefore sendmail), at least once we are using PHPMailer for both.

But maybe we should make the fact that the from address can not be detected automatically and this FAQ more prominently. Maybe even add a system check that looks up if the from mail ends with .localdomain or something like this.


@tsteur commented on May 11th 2020 Member

Made the changes @sgiehl

@tsteur commented on May 13th 2020 Member

@sgiehl I suppose it is good to merge now?

@Findus23 commented on May 13th 2020 Member

I still think that the subject line looks like a random SPAM mail.

@tsteur commented on May 14th 2020 Member

@Findus23 changed it 👍

This Pull Request was closed on May 17th 2020
Powered by GitHub Issue Mirror